Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pre-releases instead of nightly and update actions #681

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

devmotion
Copy link
Member

With setup-julia@v2 we can test min (minimum version supported) and pre (pre-releases). I think the latter might be more stable and more relevant than testing nightly.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a really good idea, thanks @devmotion!

Is there a way to see from the CI logs what the actual Julia version is that's being used? If not, might be good to print it out.

@devmotion
Copy link
Member Author

It's shown in the logs of the setup-julia step, e.g. https://github.com/TuringLang/DynamicPPL.jl/actions/runs/11158554561/job/31015074600?pr=681#step:3:10

@devmotion
Copy link
Member Author

It seems the Julia compat entry of DynamicPPL has been incorrect for ~2 years: https://github.com/TuringLang/AbstractPPL.jl/blob/1cbcd1c39547bb17732b33d2b2f7aef1edc818af/Project.toml#L21

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (184b71f) to head (f3a73a0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #681   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files          29       29           
  Lines        3591     3591           
=======================================
  Hits         2790     2790           
  Misses        801      801           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 3, 2024

Pull Request Test Coverage Report for Build 11159655625

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 78.129%

Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.46%
src/varinfo.jl 6 85.8%
src/simple_varinfo.jl 6 85.11%
src/threadsafe.jl 12 54.78%
Totals Coverage Status
Change from base Build 11151792043: 0.0%
Covered Lines: 2790
Relevant Lines: 3571

💛 - Coveralls

@devmotion devmotion added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 7f91c07 Oct 3, 2024
14 checks passed
@devmotion devmotion deleted the dw/ci branch October 3, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants