Move src/test_utils.jl and test/test_util.jl to DynamicPPLTestExt
#718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
py/testext
branch
2 times, most recently
from
6965948
to
9d8d048
Compare
penelopeysm
force-pushed
the
py/testext
branch
from
9d8d048
to
045dbe3
Compare
|
Rightttt, I forgot that you can't namespace things inside extensions. Unless you declare a function inside src/ that has no implementation and then make a new method for it in the extension. 🙄 I thought that this would make it easier to tackle TuringLang/Turing.jl#2307, apparently not. So I'll just refactor the existing code in src/test_utils. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #550 and also takes a step towards TuringLang/Turing.jl#2307
WIP, I'm expect this to cause lots of breakage.
This is a breaking change due to the different import path for TestUtils.
I intend to further split TestExt up into smaller files, not sure if that will be part of this PR or not.