Move most of TestUtils into TestExt #723
Draft
+73
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the implementations of
src/test_utils/context.jl
,src/test_utils/sampler.jl
, andsrc/test_utils/varinfo.jl
into a newDynamicPPLTestExt
extension.Benefits:
Negatives:
src/test_utils.jl
and then extend this inside TestExt with the real implementation.src/test_utils.jl
.Possible ways forward
src
.My hot take is that I'd prefer (3). Well .... kind of, at least. If we have assorted stuff that builds on DPPL, e.g. benchmarking, I still kind of feel that it would be better to have it in a separate package.
Maybe one possibility is to have the different packages in the same repo so that CI + development doesn't fall out of sync? I recognise this would require a fair bit of reorganisation.
Closes #550