Fixing CI from #711 #729
Merged
Fixing CI from #711 #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Oh sorry, I shouldn't have done that @penelopeysm ; thought i was looking at another PR 🤦 |
|
haha don't worry 😄 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Think I fixed the issues now @penelopeysm :) |
|
Thanks for picking it up! |
|
Ohhhhh, I think I know what happened with the merge queue. I had to temporarily remove the required CI checks, because of #724 (otherwise it would wait forever on the macos x64 job that wasn't being run any more), and they haven't been added back yet, so it just merges right away without checking anything. I'll fix that in the repo settings and then I think we should be back to normal. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#711
To be clear I introduced some of these errors when performing a manual merge, it's just that GitHub decided to merge the PR before I could see the outcome of CI