Remove samplers from VarInfo - Selectors and GIDs #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.35 #808 +/- ##
================================================
+ Coverage 85.78% 86.32% +0.54%
================================================
Files 36 35 -1
Lines 4207 4162 -45
================================================
- Hits 3609 3593 -16
+ Misses 598 569 -29 ☔ View full report in Codecov by Sentry. |
mhauru
requested review from
penelopeysm and
sunxd3
and removed request for
penelopeysm
|
thanks Markus, I'll take a look -- but give me a bit of time to look over and think a bit, will try to get it done tomorrow morning |
sunxd3
approved these changes
Feb 14, 2025
|
I assume the test errors are of the same sources as #804 (comment)? |
Pull Request Test Coverage Report for Build 13367790756Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the decoupling of samplers and VarInfo, this one removes the Gibbs ID field and everything related to Selectors. That is, the mechanism by which VarInfo associated different variables with different Gibbs components.
This might be the last one, but I need to do a sweep and try running the Turing.jl test suite against this version of DPPL to see that I haven't missed anything.