Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minor version #1909

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Bump minor version #1909

merged 1 commit into from
Nov 14, 2022

Conversation

torfjelde
Copy link
Member

After #1900 we should, IMO, bump the minor version given that we did so in DPPL. Technically this should be non-breaking, but I'm personally worried that there will be some unforeseen consequences OR people are simply using some internal functionality from DPPL (which did have a breaking release).

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @torfjelde - looks sensible to make a breaking release!

FYI @ChrisRackauckas, in case SciML hook into any DynamicPPL internals. We are in the process of making DynamicPPL core data structure more transparent, performant and hackable, but it might cause some disruptions along the process.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3461612003

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.241%

Totals Coverage Status
Change from base Build 3454711150: 0.0%
Covered Lines: 1152
Relevant Lines: 1418

💛 - Coveralls

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 81.24% // Head: 81.24% // No change to project coverage 👍

Coverage data is based on head (5b50e37) compared to base (1a63ece).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1909   +/-   ##
=======================================
  Coverage   81.24%   81.24%           
=======================================
  Files          21       21           
  Lines        1418     1418           
=======================================
  Hits         1152     1152           
  Misses        266      266           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yebai yebai merged commit 1e92b49 into master Nov 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the torfjelde-patch-2 branch November 14, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants