Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Bijectors to 0.14, (keep existing compat) #2385

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Bijectors package from 0.13.6 to 0.13.6, 0.14.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@penelopeysm penelopeysm force-pushed the compathelper/new_version/2024-10-30-00-31-50-526-02388504075 branch from 87a154e to 1b65681 Compare October 30, 2024 00:31
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (d2ea94a) to head (1b65681).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
- Coverage   86.45%   86.39%   -0.07%     
==========================================
  Files          22       22              
  Lines        1573     1573              
==========================================
- Hits         1360     1359       -1     
- Misses        213      214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm
Copy link
Member

penelopeysm commented Oct 30, 2024

Do not merge

This isn't actually testing Bijectors 0.14, it's using Bijectors 0.13 because it's still limited by DynamicPPL's compat entry.

cf. TuringLang/DynamicPPL.jl#701

@penelopeysm penelopeysm marked this pull request as draft October 30, 2024 00:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11584734613

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 78.685%

Files with Coverage Reduction New Missed Lines %
ext/TuringOptimExt.jl 1 98.04%
Totals Coverage Status
Change from base Build 11573267768: -0.06%
Covered Lines: 1233
Relevant Lines: 1567

💛 - Coveralls

@yebai yebai mentioned this pull request Nov 7, 2024
@yebai yebai closed this in #2384 Nov 7, 2024
@yebai yebai deleted the compathelper/new_version/2024-10-30-00-31-50-526-02388504075 branch November 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants