Adds basic MQTT support with remote events #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reinhapa
commented
Apr 5, 2023
reinhapa
commented
- adds short cut to signal restart on rc 42
- adds heartbeat over mqtt
|
Initial implementation for #906 |
mklaehn
previously approved these changes
Apr 6, 2023
mklaehn
reviewed
Apr 6, 2023
- adds short cut to signal restart on rc 42 - adds heartbeat over mqtt Signed-off-by: Patrick Reinhart <[email protected]>
|
@mklaehn addressed re-use of JsonDataConverter but switched to JSONB within. |
mklaehn
approved these changes
Apr 8, 2023
| dependencies { | ||
| implementation project(':tweetwallfx-configuration') | ||
| implementation 'org.eclipse.paho:org.eclipse.paho.client.mqttv3:1.2.5' | ||
| implementation 'org.slf4j:slf4j-api:2.0.6' |
There was a problem hiding this comment.
not strictly required at the moment as the rootProject adds it as implementation dependency to every leaf project. not bad per se...
Suggested change
| implementation 'org.slf4j:slf4j-api:2.0.6' |
|
|
||
| @Test | ||
| void convertFromInputStream() { | ||
| var is = new ByteArrayInputStream("{\"one\":\"11\",\"tree\":false,\"two\":22}".getBytes(UTF_8)); |
There was a problem hiding this comment.
This works.
with text block this would look like
Suggested change
| var is = new ByteArrayInputStream("{\"one\":\"11\",\"tree\":false,\"two\":22}".getBytes(UTF_8)); | |
| var is = new ByteArrayInputStream("""{"one":"11","tree":false,"two":22}""".getBytes(UTF_8)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.