Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stab at making scaling for ui design purposes possible. #907

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

First stab at making scaling for ui design purposes possible. #907

wants to merge 1 commit into from

Conversation

mklaehn
Copy link
Contributor

@mklaehn mklaehn commented Oct 29, 2019

No description provided.

svenreimers
svenreimers reviewed Oct 30, 2019
View reviewed changes
Copy link
Contributor

@svenreimers svenreimers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. What about different aspect ratios? How do we deal with them? Maybe just supply different subconfigurations (4:3, 16:9, 16:10) in the config and select by determining from the real screen size during start up?

config/src/main/java/org/tweetwallfx/config/TweetwallSettings.java
), super.toString());
}

public static final class Rectangle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use javafx.geometry.Dimension2D instead of creating our own little helper class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we could. I had some more properties in that class while working on this. However up to this point those properties weren't needed anymore.

@mklaehn mklaehn changed the title First stab at making sclaing for ui design purposes possible. First stab at making scaling for ui design purposes possible. Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenreimers svenreimers svenreimers left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mklaehn @svenreimers