feat(alerting): Add RESULT_CONDITIONS in custom alert to have more information #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
aalmenar
changed the title
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
3 times, most recently
from
e9223fd to
e7597a1
Compare
|
Rebased patch after: fix(alerting): Escape custom result errors |
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
2 times, most recently
from
869fdf9 to
2ddec80
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
3 times, most recently
from
1a1426e to
08eb98e
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
1e3abec to
a1a6a1b
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
2 times, most recently
from
7d9acd2 to
2dffcf0
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
2dffcf0 to
da56af1
Compare
|
It would be nice to have this on Gatus! For us it is useful to integrate it with our alert system. @TwiN Could you take a look at it? |
TwiN
requested changes
Aug 1, 2025
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
3 times, most recently
from
d12c941 to
7d13b47
Compare
|
@TwiN any comments after the changes ? |
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
7d13b47 to
b96dbb1
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
b96dbb1 to
3225f58
Compare
|
I'm working on a very large change that touches nearly half of the files, that's why I haven't looked at this yet FYI |
Since 5.24.0 is released now, can we revisit this? |
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
2 times, most recently
from
de3e119 to
6cd3393
Compare
…formation on an alert while using custom alerting module
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
6cd3393 to
67b591b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This helps solving issue: #1085
Since this adds a new placeholder shouldn't interfere with the current behaviour gatus has.
Checklist
README.md, if applicable.