fix(alerting): replace HTML entities with emojis in teams-workflows provider to prevent rendering issues #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieceofsoul
changed the title
TwiN
previously approved these changes
Dec 28, 2024
TwiN
requested changes
Dec 28, 2024
pieceofsoul
force-pushed
the
fix-teams-workflows-emojis
branch
from
910e52c to
c2132ed
Compare
|
Apologies for the oversight. I've updated the tests, and they are now passing as expected. |
TwiN
approved these changes
Jan 14, 2025
TwiN
changed the title
TwiN
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
=======================================
Coverage 76.04% 76.04%
=======================================
Files 74 74
Lines 6704 6704
=======================================
Hits 5098 5098
Misses 1304 1304
Partials 302 302 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Emojis written as HTML entities are not working as expected. Especially on mobilde devices (android) the entity is not rendered. Desktop seems to work. The assumption is that there is no full support of html entities for adaptive cards: https://learn.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/cards-format?tabs=adaptive-md%2Cdesktop%2Cdesktop1%2Cdesktop2%2Cconnector-html
However, replacing them with emojis itself, works on desktop and mobile devices.
Checklist
README.md, if applicable.Verified by running gatus locally with a local config. Desktop and mobile view are both showing the emojis in an appropriate way.