Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add gatus_results_endpoint_success #970

Merged
merged 7 commits into from
Jan 19, 2025

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Jan 19, 2025

Summary

Fixes: #969

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@onedr0p
Copy link
Contributor Author

onedr0p commented Jan 19, 2025

@TwiN here is the implementation with the README updated to help differentiate between gatus_results_total and gatus_results_endpoint_success

@onedr0p onedr0p changed the title feat(metrics): add gatus_endpoint_success feat(metrics): add gatus_results_endpoint_success Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.05%. Comparing base (3107336) to head (7ff083c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   76.02%   76.05%   +0.03%     
==========================================
  Files          74       74              
  Lines        6706     6716      +10     
==========================================
+ Hits         5098     5108      +10     
  Misses       1306     1306              
  Partials      302      302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TwiN
Copy link
Owner

TwiN commented Jan 19, 2025

@onedr0p Excellent work! Thank you for the contribution.

@TwiN TwiN merged commit 0bba77a into TwiN:master Jan 19, 2025
2 checks passed
@onedr0p onedr0p deleted the success-metric branch January 20, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric for endpoint up or down
2 participants