Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-14358] Fix mock response fixtures in 5.8.0 branch #6967

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

edsonmichaque
Copy link
Contributor

@edsonmichaque edsonmichaque commented Mar 18, 2025

User description

Description

Related Issue

https://tyktech.atlassian.net/browse/TT-14358

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

PR Type

  • Bug fix

Description

  • Removed legacy conflict markers in fixture file.

  • Replaced mock response entries with structured YAML arrays.

  • Updated multiple test fixture segments for proper API response simulation.


Changes walkthrough 📝

Relevant files
Bug fix
mock_response.yml
Update and standardize mock response fixtures.                     

apidef/oas/testdata/fixtures/mock_response.yml

  • Cleared Git merge conflict markers.
  • Replaced with valid YAML mock response arrays.
  • Standardized fixture definitions for various test cases.
  • +1/-46   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @buger
    Copy link
    Member

    buger commented Mar 18, 2025

    A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄

    Your branch: fix-mock-response-fixture

    Your PR title: Fix mock response fixtures

    Your PR description:

    Description

    Related Issue

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing functionality to change)
    • Refactoring or add test (improvements in base code or adds test coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning why it's required
    • I would like a code coverage CI quality gate exception and have explained why

    If this is your first time contributing to this repository - welcome!


    Please refer to jira-lint to get started.

    Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

    Valid sample branch names:

    ‣ feature/shiny-new-feature--mojo-10'
    ‣ 'chore/changelogUpdate_mojo-123'
    ‣ 'bugfix/fix-some-strange-bug_GAL-2345'

    Copy link
    Contributor

    API Changes

    no api changes detected

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    YAML Null Syntax

    The fixture update now uses "" in several places. Please verify that this value is correctly interpreted as null by the YAML parser and that it meets the intended behavior for mock responses. Consider switching to "null" if that aligns better with YAML standards.

    mock_response: <nil>
    white_list: <nil>

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @edsonmichaque edsonmichaque requested a review from a team as a code owner March 18, 2025 19:51
    @buger
    Copy link
    Member

    buger commented Mar 18, 2025

    A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄

    Your branch: fix-mock-response-fixture

    Your PR title: Fix mock response fixtures

    Your PR description: ### **User description**

    Description

    Related Issue

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing functionality to change)
    • Refactoring or add test (improvements in base code or adds test coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning why it's required
    • I would like a code coverage CI quality gate exception and have explained why

    PR Type

    • Bug fix

    Description

    • Removed legacy conflict markers in fixture file.

    • Replaced mock response entries with structured YAML arrays.

    • Updated multiple test fixture segments for proper API response simulation.


    Changes walkthrough 📝

    Relevant files
    Bug fix
    mock_response.yml
    Update and standardize mock response fixtures.                     

    apidef/oas/testdata/fixtures/mock_response.yml

  • Cleared Git merge conflict markers.
  • Replaced with valid YAML mock response arrays.
  • Standardized fixture definitions for various test cases.
  • +1/-46   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • If this is your first time contributing to this repository - welcome!


    Please refer to jira-lint to get started.

    Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

    Valid sample branch names:

    ‣ feature/shiny-new-feature--mojo-10'
    ‣ 'chore/changelogUpdate_mojo-123'
    ‣ 'bugfix/fix-some-strange-bug_GAL-2345'

    @edsonmichaque edsonmichaque changed the title Fix mock response fixtures [Fix mock response fixtures Mar 18, 2025
    @edsonmichaque edsonmichaque changed the title [Fix mock response fixtures [TT-14358] Fix mock response fixtures in 5.8.0 branch Mar 18, 2025
    @andrei-tyk andrei-tyk merged commit 096984d into release-5.8.0 Mar 19, 2025
    27 of 39 checks passed
    @andrei-tyk andrei-tyk deleted the fix-mock-response-fixture branch March 19, 2025 08:02
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    4 participants