Skip to content

Conversation

@solareon
Copy link

Adds the ability to create the assetName if it does not exist. Disabled by default to not change functionality

@solareon solareon requested a review from Tynopia as a code owner May 18, 2025 13:27
@Tynopia
Copy link
Owner

Tynopia commented May 19, 2025

Hi, thanks for the PR.
Everything looks good, but could you please explain:
When is process.env.RUNNER_TEMP set, and what's the reason you want to use it in the headless argument?

@solareon
Copy link
Author

Hi, thanks for the PR.

Everything looks good, but could you please explain:

When is process.env.RUNNER_TEMP set, and what's the reason you want to use it in the headless argument?

When you run the dev container locally that isn't set but if it's inside a GitHub action runner it is. Basically a good toggle for local debugging vice actual runs on the action. I believe it's already used somewhere else to skip the puppeteer install

src/types.ts Outdated
API = 'https://portal-api.cfx.re/v1/',
SSO = 'auth/discourse?return=',
NEW_ASSET = 'me/assets/',
FIND_ASSET = 'assets/?page=1&search={id}',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIND_ASSET isn't used somewhere

Copy link
Author

@solareon solareon May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I saw the hardcoded url in the utils and meant to convert it to getUrl like the others and got side tracked. fixed via e114550

@Tynopia
Copy link
Owner

Tynopia commented May 21, 2025

I am a little bit confused. FIND_ASSET is still not used in the code

@solareon
Copy link
Author

I am a little bit confused. FIND_ASSET is still not used in the code

My apologies I forgot to hit save on the other file. It's up there now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants