-
Notifications
You must be signed in to change notification settings - Fork 11
feat: create new asset if not found (optional) #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi, thanks for the PR. |
When you run the dev container locally that isn't set but if it's inside a GitHub action runner it is. Basically a good toggle for local debugging vice actual runs on the action. I believe it's already used somewhere else to skip the puppeteer install |
src/types.ts
Outdated
| API = 'https://portal-api.cfx.re/v1/', | ||
| SSO = 'auth/discourse?return=', | ||
| NEW_ASSET = 'me/assets/', | ||
| FIND_ASSET = 'assets/?page=1&search={id}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIND_ASSET isn't used somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I saw the hardcoded url in the utils and meant to convert it to getUrl like the others and got side tracked. fixed via e114550
|
I am a little bit confused. FIND_ASSET is still not used in the code |
My apologies I forgot to hit save on the other file. It's up there now |
Adds the ability to create the assetName if it does not exist. Disabled by default to not change functionality