Skip to content

Support custom schema for React comment editors - #1545

Closed
milanpoliak wants to merge 2 commits into
TypeCellOS:mainfrom
milanpoliak:commets/custom-schema
Closed

Support custom schema for React comment editors#1545
milanpoliak wants to merge 2 commits into
TypeCellOS:mainfrom
milanpoliak:commets/custom-schema

Conversation

@milanpoliak

Copy link
Copy Markdown

Making it possible to pass custom schemas to comments.

Related issue: #1543

@vercel

vercel Bot commented Mar 18, 2025

Copy link
Copy Markdown

@milanpoliak is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@milanpoliak milanpoliak changed the title Commets/custom schema Support custom schema for React comment editors Mar 18, 2025
@YousefED

YousefED commented Mar 19, 2025

Copy link
Copy Markdown
Collaborator

Awesome, thanks for creating this PR. Does this solve all your requirements? I figured it might be also be useful to allow all options of the editors to be easily customized? e.g. allow consumers to implement a function getBlockNoteEditorOptions("comment-composer") that returns the options for (in this case) the composer

PS: what are you building?

@vercel

vercel Bot commented Mar 19, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 19, 2025 6:58am

@milanpoliak

Copy link
Copy Markdown
Author

Awesome, thanks for creating this PR. Does this solve all your requirements? I figured it might be also be useful to allow all options of the editors to be easily customized? e.g. allow consumers to implement a function getBlockNoteEditorOptions("comment-composer") that returns the options for (in this case) the composer

Yeah, it solves all I need right now, but the idea of a function to provide all other options sounds really good. I won't have time to implement it today, but I can take a stab at it in the next few days.

PS: what are you building?

We are migrating our news site from WordPress to a custom CMS

@Harishri2002

Copy link
Copy Markdown

Is this issue solved? can i use this to implement mentioning in comment section?

@ArihantBapna

Copy link
Copy Markdown

what's this pr waiting on atm? would help our use-case as well

@nperez0111

Copy link
Copy Markdown
Contributor

@ArihantBapna I think what we are waiting on here is for what was outlined here: #1545 (comment)

Also, there are a number of conflicts with main, now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants