Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Liveblocks #1557

Merged
merged 10 commits into from
Apr 3, 2025
Merged

docs: Update Liveblocks #1557

merged 10 commits into from
Apr 3, 2025

Conversation

matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Mar 24, 2025 •
edited
Loading

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Apr 3, 2025 1:46pm
blocknote-website ✅ Ready (Inspect) Visit Preview Apr 3, 2025 1:46pm

@matthewlipski matthewlipski marked this pull request as ready for review March 24, 2025 16:12
nperez0111
nperez0111 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise

@nperez0111
Copy link
Contributor

  • The example is showing a Duplicate extension names found: ['liveblocksMention'] warning, also with strict mode disabled. Is this smth we need to address? Seems to work well otherwise.

I'll take another look at this. Though Tiptap will de-dupe these and only respect one of them (whichever appeared first).

  • @nperez0111 when installing @liveblocks/react-blocknote, there was an issue with peer dependencies. Specifically, it needs @blocknote/core: ^0.25.1 but 0.26.0 was provided. This seems like it should be fine as it's not a major version difference so I'm not sure why it's throwing an error. Any ideas why this might be happening? Right now we fixed it with npm install --legacy-peer-deps, but this seems hacky.
image So, technically because this is a `0.x` package, that is the correct behavior since in semver `0.x` range is treated specially. I think what liveblocks will need to specify as their peer dep is: `0.25.1 - 1.0.0` image

@matthewlipski
Copy link
Collaborator Author

We should probably wait to merge this, since the Liveblocks guys are working on resolving the 2 bullet points in the PR description

@jrowny jrowny mentioned this pull request Mar 27, 2025
Merged
@matthewlipski
Merge branch 'main' into feat/liveblocks-docs
2545b23 
# Conflicts:
#	package-lock.json
#	packages/core/package.json
@matthewlipski matthewlipski merged commit 0083f50 into main Apr 3, 2025
11 checks passed
@matthewlipski matthewlipski deleted the feat/liveblocks-docs branch April 3, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nperez0111 nperez0111 nperez0111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewlipski @nperez0111 @YousefED