-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WI #2699 Implement new command InsertVariableDisplay #2701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@efr15: Tests are failing because of hashes that differ on Linux from those we get on Windows. I'll try to fix that soon. |
efr15
requested changes
Feb 14, 2025
TypeCobol.LanguageServer.Test/RefactoringTests/RefactoringProcessorTest.cs
Show resolved
Hide resolved
TypeCobol.LanguageServer/Commands/InsertVariableDisplay/CobolStringBuilder.cs
Outdated
Show resolved
Hide resolved
TypeCobol.LanguageServer/Commands/InsertVariableDisplay/CobolStringBuilder.cs
Outdated
Show resolved
Hide resolved
TypeCobol.LanguageServer/Commands/InsertVariableDisplay/DataDefinitionHelper.cs
Outdated
Show resolved
Hide resolved
TypeCobol.LanguageServer/Commands/InsertVariableDisplay/GeneratedStatements.cs
Show resolved
Hide resolved
TypeCobol.LanguageServer/Commands/InsertVariableDisplay/GeneratedStatements.cs
Outdated
Show resolved
Hide resolved
TypeCobol.LanguageServer/Commands/InsertVariableDisplay/GeneratedStatements.cs
Outdated
Show resolved
Hide resolved
efr15
approved these changes
Feb 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⚠️ Changes requested
Pull Request needs changes before it can be reviewed again
✨ Merged
Pull Request has been merged successfully
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2699
Copy of POC_InsertVariableDisplay slightly adapted/refactored.