Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WI #2699 Implement new command InsertVariableDisplay #2701

Merged
merged 30 commits into from
Feb 17, 2025

Conversation

fm-117
Copy link
Contributor

@fm-117 fm-117 commented Jan 21, 2025

Fixes #2699

Copy of POC_InsertVariableDisplay slightly adapted/refactored.

@fm-117 fm-117 requested a review from efr15 January 21, 2025 16:59
@fm-117 fm-117 self-assigned this Jan 21, 2025
@fm-117 fm-117 linked an issue Jan 21, 2025 that may be closed by this pull request
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 21, 2025
@fm-117
Copy link
Contributor Author

fm-117 commented Jan 21, 2025

@efr15: Tests are failing because of hashes that differ on Linux from those we get on Windows. I'll try to fix that soon.

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Feb 14, 2025
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Feb 17, 2025
@fm-117 fm-117 requested a review from efr15 February 17, 2025 14:19
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Feb 17, 2025
@fm-117 fm-117 merged commit 8a01bb7 into develop Feb 17, 2025
8 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Feb 17, 2025
@fm-117 fm-117 deleted the 2699-new-command-insert-variable-display branch February 17, 2025 16:30
@efr15 efr15 mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Changes requested Pull Request needs changes before it can be reviewed again ✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: Insert Variable Display
2 participants