Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WI #2707 Avoid full source dump, keep code for future uses #2708

Merged
merged 2 commits into from
Mar 3, 2025
Merged

WI #2707 Avoid full source dump, keep code for future uses #2708

merged 2 commits into from
Mar 3, 2025

Conversation

fm-117
Copy link
Contributor

@fm-117 fm-117 commented Feb 21, 2025

Fixes #2707

@fm-117 fm-117 requested a review from efr15 February 21, 2025 07:46
@fm-117 fm-117 self-assigned this Feb 21, 2025
@fm-117 fm-117 linked an issue Feb 21, 2025 that may be closed by this pull request
Avoid logging full source code #2707
Closed
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Feb 21, 2025
@fm-117 fm-117 marked this pull request as draft February 25, 2025 08:20
@fm-117
Copy link
Contributor Author

fm-117 commented Mar 3, 2025

Ok maybe this is a bit better with the move of the method to the LoggingSystemExtensions. We still have to build a version specifically to activate full source code dump, this is not dynamic.
@efr15 tell me what you think about this PR.

@fm-117 fm-117 marked this pull request as ready for review March 3, 2025 09:49
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Mar 3, 2025
@efr15
Copy link
Contributor

efr15 commented Mar 3, 2025

An idea is to activate full source code dump by an option.
It will require also to be able to set this option client side.

But I don't know if this use case will happen in real life.
Maybe we should keep the code as is and wait for a real situation.

@fm-117 fm-117 mentioned this pull request Mar 3, 2025
Open
@fm-117 fm-117 merged commit 989318a into develop Mar 3, 2025
8 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Mar 3, 2025
@fm-117 fm-117 deleted the 2707-avoid-logging-full-source-code branch March 3, 2025 12:52
@efr15 efr15 mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efr15 efr15 efr15 approved these changes

Assignees

@fm-117 fm-117

Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid logging full source code
2 participants
@fm-117 @efr15