Clarify "No errors found." message #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it would make more sense to just say "No typescript errors found."? |
cben
changed the title
Done, PTAL. UPDATE: now also updated |
cben
force-pushed
the
patch-1
branch
2 times, most recently
from
1579b3d to
d53e1f9
Compare
piotr-oles
approved these changes
May 15, 2024
When this message appears in context of webpack-dev-server, it could be unclear what kind of errors (webpack build vs. typescript). Sometimes there is a prior "Error checking in progress" message, but not always, and may be far above the "No errors found."
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A really minor usability tweak, subjective, up to you if you like it.
In the context of webpack-dev-server, there are 2 async build processes, which may report success/failure:
webpack 5.72.0 compiled with 2 errors in 5492 ms,webpack 5.72.0 compiled successfully in 55345 msare self-explaining.There is sometimes a cyan "Type-checking in progress..." between them, but not always.
TS6133:, so clear enough.This PR tweaks the last case to say "No typescript errors found." for clarity.