fix(NOJIRA-123): strict typechecks enable noImplicitAny by default

As pointed out by @rafaell-lycan, enabling compilerOptions.strict in turn enables compilerOptions.noImplicitAny by default - unless overridden. Update logic to account for this.
Typeform · Aug 8, 2023 · 011bd86 · 011bd86
2 parents 44de8f2 + 26a1e19
commit 011bd86
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/checks/requiredTypeScript.test.ts b/src/checks/requiredTypeScript.test.ts
@@ -445,4 +445,25 @@ describe('missingTsConfigSettings', () => {
       })
     ).not.toContainEqual(expect.stringMatching(/compilerOptions.noImplicitAny/))
   })
+  it('considers compilerOptions.noImplicitAny = true if compilerOptions.strict = true', () => {
+    expect(
+      missingTsConfigSettings({
+        compilerOptions: {
+          strict: true,
+          allowUnreachableCode: false,
+        },
+      })
+    ).not.toContainEqual(expect.stringMatching(/compilerOptions.noImplicitAny/))
+  })
+  it('requires not setting compilerOptions.noImplicitAny = false if compilerOptions.strict = true', () => {
+    expect(
+      missingTsConfigSettings({
+        compilerOptions: {
+          strict: true,
+          noImplicitAny: false,
+          allowUnreachableCode: false,
+        },
+      })
+    ).toContainEqual(expect.stringMatching(/compilerOptions.noImplicitAny/))
+  })
 })
diff --git a/src/checks/requiredTypeScript.ts b/src/checks/requiredTypeScript.ts
@@ -12,6 +12,7 @@ import ignore, { Ignore as IgnoredFileFilter } from 'ignore'
 
 type TsConfig = {
   compilerOptions?: {
+    strict?: boolean
     allowUnreachableCode?: boolean
     noImplicitAny?: boolean
   }
@@ -208,7 +209,11 @@ export function missingTsConfigSettings(tsconfig: TsConfig): string[] {
     errors.push('compilerOptions.allowUnreachableCode must be false')
   }
 
-  if (tsconfig.compilerOptions?.noImplicitAny !== true) {
+  if (
+    (tsconfig.compilerOptions?.strict !== true &&
+      tsconfig.compilerOptions?.noImplicitAny !== true) ||
+    tsconfig.compilerOptions?.noImplicitAny === false
+  ) {
     errors.push('compilerOptions.noImplicitAny must be true')
   }