Skip to content

Commit

Permalink
Merge pull request #182 from Typeform/PLT-1-decomission-jira-linked
Browse files Browse the repository at this point in the history
feat(jiraLinked): remove the check
  • Loading branch information
pmlanger authored Oct 24, 2024
2 parents e516707 + c9e0a3c commit 7811a55
Show file tree
Hide file tree
Showing 9 changed files with 4 additions and 457 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-and-release-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Test skipping checks
uses: ./
with:
skipChecks: 'jira-linked,secrets-scan'
skipChecks: 'secrets-scan'
githubToken: ${{ secrets.GITHUB_TOKEN }}
dockerUsername: ${{ secrets.GITLEAKS_DOCKER_USERNAME }}
dockerPassword: ${{ secrets.GITLEAKS_DOCKER_PASSWORD }}
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ easier time rolling out new checks to teams. Win-win!

## Included Checks

- `jira-linked`: never forget a Jira Issue key in your commits or PRs
again!
- `secrets-scan`: make sure you're never ever ever commiting a secret to
your repo. _Shhh, it's a secret_ :shushing_face:
- `pii-detection`: make sure you're not uploading files with Personal Identifiable
Expand Down Expand Up @@ -40,7 +38,7 @@ commas:
```yaml
---
with:
skipChecks: 'jira-linked,secret-scan'
skipChecks: 'secret-scan,required-typescript'
```
Refer to the [list of checks](#included-checks) for the proper names
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inputs:
description: 'Optional checks to enable'
githubToken:
required: true
description: 'The github token to get PR info when checking for Jira Issue key'
description: 'Required for checks that need access to Github'
runs:
using: 'node20'
main: 'dist/index.js'
131 changes: 0 additions & 131 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

Loading

0 comments on commit 7811a55

Please sign in to comment.