fix(NOJIRA-123): post adoption comment if js files are renamed to ts

In a PR where a single file is being renamed from file.js to file.ts, even though the TS adoption is changing, the comment is being posted because only the old filename of the changed file ends in .js. Adds a condition for detecting renames.
Typeform · Sep 29, 2023 · 8cf600d · 8cf600d
2 parents ef0f017 + d92d887
commit 8cf600d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/checks/requiredTypeScript.ts b/src/checks/requiredTypeScript.ts
@@ -60,6 +60,12 @@ async function checkPullRequest(): Promise<boolean> {
 
   const files = await github.getPullRequestFiles(pr.number)
   const jsFiles = files.filter((f) => isForbiddenJSFile(f.filename, filter))
+  const renamedJsFiles = files.filter(
+    (f) =>
+      f.previous_filename &&
+      isForbiddenJSFile(f.previous_filename) &&
+      !jsFiles.includes(f)
+  )
   const tsconfigFiles = await fs.glob({
     patterns: ['**/tsconfig.json'],
     exclude: filter,
@@ -74,7 +80,7 @@ async function checkPullRequest(): Promise<boolean> {
     )
   }
 
-  if (jsFiles.length || errors.length > 0) {
+  if (jsFiles.length || renamedJsFiles.length || errors.length > 0) {
     const adoption = await measureTsAdoption(filter)
     const commentId = await github.pinComment(
       pr.number,