Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button in GUI to export a single channel by ID #1253

Closed
wants to merge 8 commits into from

Conversation

AlmightyLks
Copy link

@AlmightyLks AlmightyLks commented Jun 24, 2024

Reason for PR

Users tend to get frustrated or impatient with the GUI which loads all guilds and all channels. Especially when including Threads.
The CLI, which can easily do this selectively, however is way too complicated for laymen who have never seen an open command line.
Thus, for accessibility reasons, we could allow the quick-export functionality of a given specific channel id via the GUI as well.


Changes:

New starting view, added the flash button:

image

image

The Flash Button toggles a new input, which allows to export a single channel via a given Id:

image

Which functions like hitting Export on a singular channel when going for the elaborate way through the list of all guilds and all channels:

image

@AlmightyLks AlmightyLks marked this pull request as ready for review June 24, 2024 21:35
@Tyrrrz
Copy link
Owner

Tyrrrz commented Jun 25, 2024

Hi. First of all, thanks for the PR. It looks really nice.

I have some suggestions regarding the UI:

  1. The lightning icon, I fear, is not super descriptive. How about using the pound symbol icon (#)? Could use the outline variant so as to not get confused with the channel icon in the channel list. I think the # symbol is great for this functionality because it's associated in Discord with IDs.
  2. Instead of expanding the top section to fit another textbox, let's just show a new dialog instead.
  3. On that dialog, we should allow the user to enter multiple channel IDs by separating them with newlines. Somewhat similar to this: https://github.com/Tyrrrz/YoutubeDownloader/blob/ba1bf900263b5ca64702ef34f1e375b44c0cdf0b/YoutubeDownloader/Views/Components/DashboardView.axaml#L22-L30

@AlmightyLks
Copy link
Author

AlmightyLks commented Jun 25, 2024

Hey

  1. I suppose, easy fix
  2. That's what I feared, as this initial way via the main window was the easiest and fastest, where all dependencies were already in place 😆This might take me a second, because I am not used to Desktop Dev, XAML nor Avalonia (or WPF)
  3. Aight

Still WIP

@Tyrrrz
Copy link
Owner

Tyrrrz commented Aug 6, 2024

Hey there @AlmightyLks.

Are you planning on continuing with this PR or do you no longer have time/interest for it?

@Tyrrrz Tyrrrz changed the title Add Option to DCE GUI to Quick-Export via given Channel Id Add button in GUI to export a single channel by ID Aug 6, 2024
@AlmightyLks
Copy link
Author

Speaking for myself, I honestly will drop the PR. Maybe someone else picks up on it or something. 😄

@Tyrrrz
Copy link
Owner

Tyrrrz commented Aug 6, 2024

Okay, no worries. Thanks for putting in effort :)

@Tyrrrz Tyrrrz added invalid and removed enhancement labels Aug 6, 2024
@Tyrrrz Tyrrrz closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants