Skip to content

Commit

Permalink
Fix reviews (#113)
Browse files Browse the repository at this point in the history
* fix: Update README.md structure to move Python Ecosystem Fit after summary

Update README.md structure to move Python Ecosystem Fit to appear after the summary

* Fix: Create get_bmr.py function in new file

Fix: Create a new file for the BMR function

* fix: Create get_tdee.py as a new file

Create a new file for tdee function to fix comment from milestone 2

* Fix: Create unit_convert.py

Create a new file for the unit convertor function

* Fix: updated the test functions to cover changes to the functions

* Fix: Updated the cicd

* Updated the toml file

* update the readthedoc.yml with python version 3.11
  • Loading branch information
Forsythia-olive authored Feb 4, 2025
1 parent 0a75c99 commit 13958ab
Show file tree
Hide file tree
Showing 4 changed files with 164 additions and 375 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
needs: ci

# Allow main and ci-cd-integration branches to trigger the release
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/ci-cd-integration'
if: github.event_name == 'push' && github.ref == 'refs/heads/main'

# Set up operating system
runs-on: ubuntu-latest
Expand All @@ -60,29 +60,29 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }} # forgive just added this

- name: Use Python Semantic Release to prepare release
id: release
uses: python-semantic-release/python-semantic-release@v8.7.0
uses: python-semantic-release/python-semantic-release@v8.3.0 # changed from 8.7 to 8.3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
force: true

# removed force = true
- name: Publish to TestPyPI
uses: pypa/gh-action-pypi-publish@release/v1
if: ${{ steps.release.outputs.released == 'true' }}
if: steps.release.outputs.released == 'true'
with:
repository-url: https://test.pypi.org/legacy/
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
verbose: true
# removed verbose = true

- name: Test install from TestPyPI
if: ${{ steps.release.outputs.released == 'true' }}
if: steps.release.outputs.released == 'true'
run: |
pip install \
--index-url https://test.pypi.org/simple/ \
--extra-index-url https://pypi.org/simple \
healthsciencecalculator==${{ steps.release.outputs.version }}
healthsciencecalculator
- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ version: 2
build:
os: ubuntu-22.04
tools:
python: "3.9"
python: "3.11"
jobs:
post_create_environment:
# Install poetry
Expand Down
Loading

0 comments on commit 13958ab

Please sign in to comment.