Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address RGB print output and skimage confusion #180

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

Arc-Celt
Copy link
Collaborator

@Arc-Celt Arc-Celt commented Feb 3, 2025

Thanks Jenny for fixing the intro! It clearly explains all the packages used in our tutorial, so I don't have much explanation to add for skimage.

Changes

  • Shortened printed RGB arrays in tutorial by displaying only the first 3 rows and columns
  • Used pillow for image import and clarified skimage is not required to run the package, only for sample images
  • Used direct imports from sharpedge (enabled via __init__.py)

…utorial by displaying only the first 3 rows and columns
…ow for image import and clarified skimage is not required to run the package
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d8708d7) to head (fe7059e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          308       308           
=========================================
  Hits           308       308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@InderKhera InderKhera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end!

@hankunxiao
Copy link
Collaborator

Looks good to me! I am merging it to main.

@hankunxiao hankunxiao merged commit ca8409f into main Feb 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment