Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

58 make mutate not edit inplace #60

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Conversation

farrandi
Copy link
Collaborator

No description provided.

@farrandi farrandi linked an issue Jan 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8d5b8a) 100.00% compared to head (d1fada9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           37        37           
=========================================
  Hits            37        37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@786213750 786213750 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Collaborator

@zth96 zth96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

@farrandi farrandi merged commit 41cbbee into main Jan 27, 2024
4 of 6 checks passed
@farrandi farrandi deleted the 58-make-mutate-not-edit-inplace branch January 27, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mutate not edit inplace
3 participants