Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select column str addressed #94

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

zth96
Copy link
Collaborator

@zth96 zth96 commented Feb 1, 2024

In the docstring for the select function, *columns should not be a list of str. Addressed.

@zth96 zth96 linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9da5e27) 100.00% compared to head (b09fc58) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           39        39           
=========================================
  Hits            39        39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@farrandi farrandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zth96 zth96 changed the title Fix: select column str addressed fix: select column str addressed Feb 3, 2024
@zth96 zth96 merged commit 2436b6d into main Feb 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: select columns str
4 participants