Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated the function by adding some type hints. Improved the functionality of plotify() function by returning the plots in a dictionary and also allowing the users to save the plots to a directory. #50

Merged
merged 4 commits into from
Feb 2, 2025

Conversation

ismailbhinder
Copy link
Collaborator

Addressed the following issues:

  1. Jiayi:
  • Maybe add some type hints to datpro.py
  • Add some functions to return the actual visualization? Currently, it only displays. It would be useful to get the plots back.
  1. By TA/Instructor:
  • Plotting code should have more arguments such as file name, path to save to, etc.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a4400a8) to head (1482388).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           90       104   +14     
=========================================
+ Hits            90       104   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DongchunChen DongchunChen merged commit c392b21 into main Feb 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants