Skip to content

Commit

Permalink
Merge pull request #20 from UBC-MDS/Update_contributing_file
Browse files Browse the repository at this point in the history
Update CONTRIBUTING.md
  • Loading branch information
kuo4230 authored Jan 11, 2025
2 parents 237d85e + fedee34 commit ae8de25
Showing 1 changed file with 30 additions and 27 deletions.
57 changes: 30 additions & 27 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ All contributions, suggestions, and feedback are accepted under the [Project’s
To contribute, you must first be invited by the administrators of the [UBC-MDS GitHub organization](https://github.com/UBC-MDS). Once you have access:

1. **Clone the Repository**
Fork the `datastructpy` repository on GitHub, then clone your fork to your local machine. For more details on forking, see the [GitHub Documentation](https://help.github.com/en/articles/fork-a-repo).
Fork the `datastructpy` repository on GitHub, then clone your fork to your local machine. For more details on forking, see the [GitHub Documentation](https://help.github.com/en/articles/fork-a-repo).

```bash
git clone https://github.com/YOUR-USERNAME/datastructpy.git
```
```bash
git clone https://github.com/YOUR-USERNAME/datastructpy.git
```

2. **Sync Your Fork**
To keep your fork up-to-date with changes in the main repository, use the fetch upstream button on GitHub.
2. **Sync Your Fork**
To keep your fork up-to-date with changes in the main repository, use the fetch upstream button on GitHub.

### Creating a Branch

Expand All @@ -30,34 +30,37 @@ git switch -c <your-branch-name>

With this branch checked out, make the desired changes to the project.

Creating a Pull Request
### Creating and Submitting a Pull Request (PR)

When you’re ready to submit your changes:
1. Commit Your Changes
1. **Commit Your Changes**
Add and commit your changes to the new branch:

```bash
git add <modified-files>
git commit -m "Descriptive message about your changes"
git push origin <your-branch-name>
```
```bash
git add <modified-files>
git commit -m "Descriptive message about your changes"
git push origin <your-branch-name>
```

2. Submit a Pull Request
Go to the GitHub repository page and create a pull request (PR) from your branch to the main repository. Follow these steps:
• Provide a clear description of the changes you made and their purpose.
• Tag an administrator or maintainer as a reviewer to ensure your PR is reviewed promptly.
For detailed instructions, refer to Creating a Pull Request.
3. Communicate in the Pull Request
Use the PR discussion thread to communicate with reviewers and collaborators. Respond to feedback and push updates to your branch as needed.
2. **Submit a Pull Request**
Go to the GitHub repository page and create a pull request from your branch to the main repository.
Follow these steps:

### Getting Your PR Merged
* Provide a clear description of the changes you made and their purpose.
* Tag an administrator or maintainer as a reviewer to ensure your PR is reviewed promptly.

After submitting your Pull Request (PR), reviewers may provide feedback or request changes. Make the necessary updates in your branch and push the changes to automatically update the PR. Once your PR is approved, it can be merged into the main branch.
4. **Communicate in the Pull Request**
Use the PR discussion thread to communicate with reviewers and collaborators. Respond to feedback and push updates to your branch as needed.

### Getting Your Pull Request Merged

After submitting your Pull Request, reviewers may provide feedback or request changes. Make the necessary updates in your branch and push the changes to automatically update the PR. Once your PR is approved, it can be merged into the main branch.

### Additional Notes
• Follow existing code style and conventions in the project.
• Update relevant documentation (if applicable) as part of your PR.
• Ensure new features are thoroughly tested and maintain existing functionality.
• Keep communication polite and constructive in all project-related discussions.

Thank you for contributing to datastructpy! Your efforts help make this project better for everyone :)
* Follow existing code style and conventions in the project.
* Update relevant documentation (if applicable) as part of your PR.
* Ensure new features are thoroughly tested and maintain existing functionality.
* Keep communication polite and constructive in all project-related discussions.

Thank you for contributing to datastructpy! Your efforts help make this project better for everyone :)

0 comments on commit ae8de25

Please sign in to comment.