Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality change for search method #22

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

javiermtzo99
Copy link
Collaborator

Change functionality for the search method and add the descriptions to the ReadME

@javiermtzo99 javiermtzo99 requested a review from kuo4230 January 11, 2025 22:02
README.md Outdated Show resolved Hide resolved
@AzinPiran AzinPiran self-requested a review January 11, 2025 22:09
Copy link
Collaborator

@kuo4230 kuo4230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added one minor comment on the wording. Also could you add your list_to_tree in the method under the class docstring? (e.g. class BinarySearchTree:
"""
A class representing a binary search tree (BST).
Methods
-------
insert(key)
Inserts a key into the BST.
delete(key)
Deletes a key from the BST.
search(key)"

Copy link
Collaborator

@kuo4230 kuo4230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Please merge to main:)

@javiermtzo99 javiermtzo99 merged commit 432097e into main Jan 11, 2025
2 of 4 checks passed
@javiermtzo99 javiermtzo99 deleted the proofreading_search_method branch January 11, 2025 22:28
@kuo4230 kuo4230 linked an issue Jan 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M1: Proof-read, create release & submit assignment
3 participants