Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality and tests for the search function #38

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Add functionality and tests for the search function #38

merged 1 commit into from
Jan 18, 2025

Conversation

javiermtzo99
Copy link
Collaborator

Add search functionality with BFS & DFS and corresponding tests

  • Implement search method in BinarySearchTree supporting DFS (default) and BFS
  • Add validation for invalid search algorithm inputs
  • Improve list_to_tree usage in test fixture for efficiency
  • Create comprehensive pytest tests for DFS and BFS search
  • Fix invalid escape sequence warning in test docstrings

@javiermtzo99
Copy link
Collaborator Author

image

@javiermtzo99 javiermtzo99 added this to the Milestone 2 milestone Jan 18, 2025
This was referenced Jan 18, 2025
Closed
Closed
kuo4230
kuo4230 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@kuo4230 kuo4230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and ready to merge.

AzinPiran
AzinPiran approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@AzinPiran AzinPiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but just in the README file we need to update the syntax for importing this package as everything is updated.

@AzinPiran AzinPiran merged commit 0e2c74f into main Jan 18, 2025
2 of 4 checks passed
@kuo4230 kuo4230 linked an issue Jan 18, 2025 that may be closed by this pull request
M2: Create Unit Tests for Search Function #30
Closed
@kuo4230 kuo4230 deleted the search_function branch January 21, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuo4230 kuo4230 kuo4230 approved these changes

@AzinPiran AzinPiran AzinPiran approved these changes

@Albert0011 Albert0011 Awaiting requested review from Albert0011

Assignees

@javiermtzo99 javiermtzo99

Labels
None yet
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.

M2: Create Unit Tests for Search Function
3 participants
@javiermtzo99 @kuo4230 @AzinPiran