53 fix feedback tas feedback re check multicollinearity #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psingh238
requested changes
Feb 2, 2025
|
|
||
| def test_function_output_incorrect_dtype(): |
There was a problem hiding this comment.
Duplicate function name, would be better to merge them both and test both cases in the same function or renaming the function name to specify what is being tested.
tests/test_multicollinearity.py
Outdated
agendazhang
approved these changes
Feb 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage ? 97.65%
=======================================
Files ? 5
Lines ? 128
Branches ? 0
=======================================
Hits ? 125
Misses ? 3
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Psingh238
approved these changes
Feb 3, 2025
Psingh238
deleted the
53-fix-feedback-tas-feedback-re-check_multicollinearity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed the following comments:
"check_multicollinearity" function did not check if input variables are of the correct datatype.
For "test_multicollinearity_wrong_input.py" did not test for if the input variabales are as expected, and if errors are raised when the input variable is not of an expected data type (e.g., expect train_df as dataframe but user uses a list)
("tests/test_multicollinearity.py", "tests/test_multicollinearity_wrong_input.py") are not well documented.