Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:refactored tests to a common format with fixtures #52

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

siddart-1
Copy link
Collaborator

Changes made:

  • Extracted test data into fixtures using pytest.fixture decorator.
  • Reduced the number of test functions by combining similar tests.
  • Used the sorted function to simplify the expected output in some tests.
  • Improved test function names and docstrings for better clarity.
  • Removed redundant assert isinstance checks, as they are implicit in the assert statements.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (502f47b) to head (b1bf4d5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   97.33%   93.33%   -4.00%     
==========================================
  Files           6        6              
  Lines         150      150              
==========================================
- Hits          146      140       -6     
- Misses          4       10       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarekB19 MarekB19 merged commit 78e8845 into main Feb 4, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants