UBC-MDS / traders_copilot_mzza_25 Public

Notifications You must be signed in to change notification settings
Fork 0
Star 0

Code
Issues 11
Pull requests 5
Actions
Projects 3
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Issues: UBC-MDS/traders_copilot_mzza_25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 Open 31 Closed

Author

Filter by author

Label

Filter by label

Use alt + click/return to exclude labels

or ⇧ + click/return for logical OR

Projects

Filter by project

Milestones

Filter by milestone

Assignee

Filter by who’s assigned

Assigned to nobody

Sort

Sort by

Newest Oldest Most commented Least commented Recently updated Least recently updated Best match

Most reactions

Issues list

Additional Feedback

#66 opened Feb 2, 2025 by abbyturi

In the documentation, the term "Prerequisites" might be misleading, as it usually refers to system requirements or dependencies. Since the listed steps guide users through using the package rather than setting up dependencies, a more appropriate heading would be "Getting Started" or "Workflow" to better reflect its purpose. Consider updating it in the documentation menu bar:Prerequisites Section

#56 opened Jan 29, 2025 by abbyturi

Currently, plot_signals() generates a visualization, but it lacks customization options for colors, labels, and grid settings. Allowing users to modify these parameters would improve usability, especially for traders who prefer specific styles.

#55 opened Jan 29, 2025 by abbyturi

Update badges for test coverage, repo status, current package version, and Python versions supported. I believe this is a requirement for Milestone 4 though which is to be done this week anyway!

#53 opened Jan 29, 2025 by abbyturi

Update: running poetry add --group dev pytest-cov, then poetry install, runs the test, then I had to update each test file to import from the correct path. For example in the test_generate_signals.py file, I updated the function import line to from traders_copilot_mzza_25.generate_signals import generate_signals. I updated all the files locally and was able to view the coverage report

#51 opened Jan 29, 2025 by abbyturi

I would also suggest tidying up the README.md file a bit, for example including backticks around code to run in the "Installation" section of the README file running pytest tests/ --cov=traders_copilot_mzza_25 is not working for me. It looks like you may be missing this in your dependencies in your pyproject.toml file under [tool.poetry.group.dev.dependencies]

#50 opened Jan 29, 2025 by abbyturi

It would be helpful if you had a "Developer Note" in your README.md file, giving instructions on how to clone and run the package on a local computer - for example if there is an environment needed to be set up or what tests to run.

#48 opened Jan 29, 2025 by abbyturi

Reviews to be addressed

#46 opened Jan 29, 2025 by abbyturi

6 of 11 tasks

Update Changelog.md

#43 opened Jan 28, 2025 by zananpech

Package License

#42 opened Jan 28, 2025 by abbyturi

Fix failed ci pipeline

#41 opened Jan 27, 2025 by zananpech

ProTip! Add no:assignee to see everything that’s not assigned.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly