Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVCD::wcdispatch [NOT READY] #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

calnaren
Copy link

@calnaren calnaren commented Mar 2, 2015

No description provided.

@immesys immesys changed the title wcdispatch for svcd implemented in svcd.c SVCD::wcdispatch Mar 2, 2015
@immesys
Copy link
Contributor

immesys commented Mar 2, 2015

This looks good at a glance, have you tested it?

@calnaren
Copy link
Author

calnaren commented Mar 2, 2015

I tested it and it works fine. But I'm not sure if my methodology of testing is correct. All I did was modify the svcd.lua such that "SVCD.wcdispatch = storm.n.wcdispatch" and ran the example given in the lab. Is this enough or is there something else needed?

@immesys
Copy link
Contributor

immesys commented Mar 2, 2015

This code path is used when you receive a response for a write. Did you verify that whatever response handler you gave to the write when you speak to a remote service is correctly invoked?

@calnaren
Copy link
Author

calnaren commented Mar 2, 2015

I'm not sure if I tried that previously but my phone bluetooth application is causing some trouble now and my other firestorm's BLE stopped working. Can I confirm this after I test it with another phone tomorrow morning?

@immesys
Copy link
Contributor

immesys commented Mar 2, 2015

You need to do the write over 15.4, not bluetooth. This is the handler for a socket.

@immesys
Copy link
Contributor

immesys commented Mar 2, 2015

But yes you can finish testing tomorrow. I will mark it as not ready, although I don't see anything wrong with the code - it is always good to have done a test which actually executes the code path you are testing.

@immesys immesys changed the title SVCD::wcdispatch SVCD::wcdispatch [NOT READY] Mar 2, 2015
@calnaren
Copy link
Author

calnaren commented Mar 3, 2015

I've tested this code and it works correctly. Sorry about not being done with this yesterday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants