princess list removed UCBoulder/oit_dingo#1230

[protitude]

Describe context / purpose for this PR

Retire princess

Issue link

#1230

Any other related PRs?

• https://github.com/UCBoulder/oit_dingo/pull/1231
• princess: clean up old code oit#18

Link to MultiDev instance

http://md-1230-ucbsub-oit.pantheonsite.io

Checklist for PR author

• I have checked that the PR is ready to be merged
• I have reviewed the DIFF and checked that the changes are as expected
• I have assigned myself or someone else to review the PR

[Copilot]

Pull request overview

This PR retires the “princess” (DDS) feature set from the servicenow Drupal module by removing the related services, routes, plugins, form, config, and database artifacts.

Changes:

• Removed princess list/lookup plugins, service definitions, and the department-selection route/form.
• Removed princess-related user field updates and form-alter logic from servicenow.module and ServicenowUserLookup.
• Added update hooks to delete the princess node/webform and drop the princess_list table; removed the princess_rebuild config key.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Plugin/ServicenowUserLookup.php	Stops writing princess-related user fields during ServiceNow profile sync.
src/Plugin/ServicenowFetchSettings.php	Removes princess rebuild getters/setters, leaving only drupal form list flag access.
src/Plugin/PrincessList.php	Deleted: removes princess list caching/rebuild logic.
src/Plugin/LookupPrincess.php	Deleted: removes “lookup princess user” helper.
src/Form/ServicenowDepartment.php	Deleted: removes the department selection form used by princess flow.
servicenow.services.yml	Removes princess-related services from the container.
servicenow.routing.yml	Deleted: removes the /desktop-support-dept route.
servicenow.module	Removes princess-specific form-alter + submit handling + cron reload behavior.
servicenow.install	Adds update hooks to delete princess content and drop the princess table; removes install/schema logic for it.
config/install/servicenow.settings.yml	Removes princess_rebuild default config entry.

Comments suppressed due to low confidence (1)

src/Plugin/ServicenowUserLookup.php:50

• In the no-secondary-department branch you assign $department2 = '' but never write it back to the user entity. If a user previously had field_user_department2 set and then loses u_secondarydepartment, the old value will remain stale. Consider explicitly clearing field_user_department2 in the else branch (and/or when u_secondarydepartment is empty).

        if (!empty($result->result[0]->u_secondarydepartment->value)) {
          $query_dept2 = ['sys_id' => $result->result[0]->u_secondarydepartment->value];
          $dept2 = $api_call->apiCallMeMaybe('cmn_department', $query_dept2);
          $department2 = Xss::filter($dept2->result[0]->name);
          $account->set('field_user_department2', $department2, TRUE);
        }
        else {
          $department2 = '';
        }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.