Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display state transition messages in Console #107

Merged
merged 8 commits into from
Jun 1, 2024
Merged

Display state transition messages in Console #107

merged 8 commits into from
Jun 1, 2024

Conversation

vrushang1234
Copy link
Contributor

@vrushang1234 vrushang1234 commented Jun 1, 2024 •
edited by taesungh
Loading

Store messages in PodData to display in Console.
Resolves #56.

@taesungh taesungh changed the title State transition message Display state transition messages in Console Jun 1, 2024
taesungh
taesungh requested changes Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the more generalized messages approach. Some additional notes on things to improve/clean up.

control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/Console.tsx Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/Console.tsx Outdated Show resolved Hide resolved
ryescholin
ryescholin approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@ryescholin ryescholin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

taesungh
taesungh approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now, please squash during merge.

@vrushang1234 vrushang1234 merged commit c22567b into main Jun 1, 2024
2 checks passed
@taesungh taesungh deleted the state-transition-message branch June 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryescholin ryescholin ryescholin approved these changes

@taesungh taesungh taesungh approved these changes

@samderanova samderanova samderanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GUI] Display state transition messages in Console
4 participants
@vrushang1234 @samderanova @taesungh @ryescholin