Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dynamics page and react router #115

Merged
merged 9 commits into from
Jun 1, 2024
Merged

Added dynamics page and react router #115

merged 9 commits into from
Jun 1, 2024

Conversation

vrushang1234
Copy link
Contributor

@vrushang1234 vrushang1234 commented Jun 1, 2024 •
edited by taesungh
Loading

Used react router to route through pages and made a new page for dynamics. Include visualization of orientation from gyroscope/accelerometer.
Resolves #103.

taesungh
taesungh reviewed Jun 1, 2024
View reviewed changes
control-station/src/App.tsx Outdated Show resolved Hide resolved
control-station/src/components/Dynamics/Dynamics.tsx Outdated Show resolved Hide resolved
taesungh
taesungh reviewed Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More minor notes.

control-station/src/views/Dynamics/Dynamics.tsx Outdated Show resolved Hide resolved
control-station/src/views/Dynamics/Dynamics.tsx Outdated Show resolved Hide resolved
control-station/src/App.tsx Outdated Show resolved Hide resolved
ryescholin
ryescholin approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@ryescholin ryescholin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw it work

taesungh
taesungh approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. For future reference, might have been nice to have a separate PR just to set up routing, but not a huge deal here. Please squash during merge.

@vrushang1234 vrushang1234 merged commit 7133018 into main Jun 1, 2024
2 checks passed
@taesungh taesungh deleted the Dynamics-main branch June 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryescholin ryescholin ryescholin approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GUI] Dynamics page
3 participants
@vrushang1234 @taesungh @ryescholin