Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Control Station and Pod Operation GitHub workflows #15

Merged
merged 13 commits into from
Feb 24, 2024
Merged

Add Control Station and Pod Operation GitHub workflows #15

merged 13 commits into from
Feb 24, 2024

Conversation

samderanova
Copy link
Contributor

@samderanova samderanova commented Feb 2, 2024 •
edited
Loading

Resolves #10.

  • Use ESLint, Prettier, and npm run build to lint, format, and test building control-station respectively
  • Use cargo clippy, cargo fmt, and cargo build to lint, format, and test building pod-operation respectively

@samderanova samderanova linked an issue Feb 2, 2024 that may be closed by this pull request
Set up checks workflow #10
Closed
@samderanova samderanova requested a review from taesungh February 2, 2024 02:07
taesungh
taesungh requested changes Feb 4, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on combining the workflows and jobs. The workflows also didn't run on the pull request: the files will need to be moved to .github/workflows/.

.github/pod-operation.yml Outdated Show resolved Hide resolved
.github/pod-operation.yml Outdated Show resolved Hide resolved
.github/pod-operation.yml Outdated Show resolved Hide resolved
.github/pod-operation.yml Outdated Show resolved Hide resolved
@samderanova
Simplify pod operation workflow
0cfcfee 
- Combine the jobs into one single job with multiple steps, similar to
  the control station workflow
- Use only actions-rs/cargo instead of multiple actions
@samderanova
Add default working directory flags
9dcae2a
@samderanova
Use 'run: cargo ...' instead of cargo action
43dcede
@samderanova
Workflow fixes:
5dd493c 
- Set workflow to use `stable` toolchain
- Set working directory for reviewdog to be `control-station`
@samderanova
Install Prettier
1c1a507
@samderanova samderanova requested review from taesungh and a team February 12, 2024 22:35
taesungh
taesungh approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks for working on this.

@samderanova samderanova requested a review from a team February 16, 2024 18:19
taesungh
taesungh reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional notes which would be nice to address but not critical.

.github/workflows/run-checks.yml Outdated Show resolved Hide resolved
.github/workflows/run-checks.yml Outdated Show resolved Hide resolved
@taesungh taesungh changed the title Control Station and Pod Operation GitHub workflows Add Control Station and Pod Operation GitHub workflows Feb 24, 2024
@taesungh taesungh merged commit f4b0d52 into main Feb 24, 2024
2 checks passed
@samderanova samderanova mentioned this pull request Feb 24, 2024
Closed
@taesungh taesungh mentioned this pull request Feb 24, 2024
Merged
4 tasks
@taesungh taesungh deleted the setup/checks-workflow branch April 30, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up checks workflow
2 participants
@samderanova @taesungh