Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary control panel design #16

Merged
merged 15 commits into from
Mar 4, 2024
Merged

Add preliminary control panel design #16

merged 15 commits into from
Mar 4, 2024

Conversation

vrushang1234
Copy link
Contributor

@vrushang1234 vrushang1234 commented Feb 2, 2024

Initial Commit for NewGUI

Closes #2

  • Converted the Javascript code into typescript
  • All of the values shown on the GUI currently are static values and haven't used any states to change them in real-time (hardcoded)

@taesungh taesungh changed the title Initial Commit Add preliminary control panel design Feb 4, 2024
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Several notes about using class names instead of ids, more flexible CSS styles, and reorganizing files. Additionally, please reformat source files with Prettier.

control-station/public/Data/Images/HX Logo.png Outdated Show resolved Hide resolved
control-station/src/App.tsx Outdated Show resolved Hide resolved
control-station/src/components/ControlPanel/style.css Outdated Show resolved Hide resolved
control-station/src/index.css Outdated Show resolved Hide resolved
control-station/src/components/ControlPanel/style.css Outdated Show resolved Hide resolved
control-station/src/components/ControlPanel/style.css Outdated Show resolved Hide resolved
control-station/src/components/Navbar/Navbar.tsx Outdated Show resolved Hide resolved
control-station/src/components/Navbar/Navbar.tsx Outdated Show resolved Hide resolved
@taesungh taesungh mentioned this pull request Feb 4, 2024
@vrushang1234
Copy link
Contributor Author

Fixed most of the issues except using classes instead of IDs as I tried to reuse the classes as much as possible in the initial commit. Also added a state and context for console list.

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to limit the scope of changes: we were looking to review the preliminary visual design and file structure before incorporating functionality. As such, could you revert the changes on adding the context and state?

There are still some lingering comments from the first review, including reformatting files with Prettier.

control-station/.gitignore Outdated Show resolved Hide resolved
control-station/vite.config.ts Outdated Show resolved Hide resolved
@vrushang1234
Copy link
Contributor Author

Please try to limit the scope of changes: we were looking to review the preliminary visual design and file structure before incorporating functionality. As such, could you revert the changes on adding the context and state?

There are still some lingering comments from the first review, including reformatting files with Prettier.

I use prettier locally. Do you mean I have to add Prettier to the eslint?

@taesungh
Copy link
Member

Perhaps something went wrong locally: the TSX and CSS files do not appear to be formatted. You can also use the Prettier extension for VS Code.

@samderanova
Copy link
Contributor

Additionally, we might want to consider having some sort of .prettierrc configuration so that the formatting is consistent for all of us.

@taesungh
Copy link
Member

Additionally, we might want to consider having some sort of .prettierrc configuration so that the formatting is consistent for all of us.

Included in control-station/.prettierrc from d5cc776.

@samderanova
Copy link
Contributor

Sorry I thought it wasn't included since I didn't see it in the list of changes for this PR. Please disregard my comment.

@vrushang1234
Copy link
Contributor Author

Perhaps something went wrong locally: the TSX and CSS files do not appear to be formatted. You can also use the Prettier extension for VS Code.

I can't seem to find the problem as I use the prettier extension for VSCode. I'll try to npm run format before pushing from now on.

control-station/vite.config.ts Outdated Show resolved Hide resolved
control-station/src/views/Dashboard/Dashboard.tsx Outdated Show resolved Hide resolved
control-station/src/App.tsx Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/sensorboxct.css Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/sensorboxct.css Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/sensorboxct.css Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/sensorboxct.css Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/sensorboxct.css Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/sensorboxct.css Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/sensorboxct.css Outdated Show resolved Hide resolved
control-station/src/index.css Outdated Show resolved Hide resolved
control-station/src/index.css Outdated Show resolved Hide resolved
control-station/index.html Outdated Show resolved Hide resolved
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to revisit some of the styling concerns (perhaps look into Bootstrap as Sam suggested) and component hierarchy (particularly within SensorBoxes), but this will work for now.

@taesungh taesungh merged commit ad043cf into main Mar 4, 2024
2 checks passed
@taesungh taesungh mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design preliminary control panel
4 participants