-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary control panel design #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Several notes about using class names instead of ids, more flexible CSS styles, and reorganizing files. Additionally, please reformat source files with Prettier.
control-station/src/components/SensorBoxes/Camera&Console/Camera.tsx
Outdated
Show resolved
Hide resolved
Fixed most of the issues except using classes instead of IDs as I tried to reuse the classes as much as possible in the initial commit. Also added a state and context for console list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to limit the scope of changes: we were looking to review the preliminary visual design and file structure before incorporating functionality. As such, could you revert the changes on adding the context and state?
There are still some lingering comments from the first review, including reformatting files with Prettier.
I use prettier locally. Do you mean I have to add Prettier to the eslint? |
Perhaps something went wrong locally: the TSX and CSS files do not appear to be formatted. You can also use the Prettier extension for VS Code. |
Additionally, we might want to consider having some sort of |
Included in |
Sorry I thought it wasn't included since I didn't see it in the list of changes for this PR. Please disregard my comment. |
I can't seem to find the problem as I use the prettier extension for VSCode. I'll try to npm run format before pushing from now on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to revisit some of the styling concerns (perhaps look into Bootstrap as Sam suggested) and component hierarchy (particularly within SensorBoxes
), but this will work for now.
Initial Commit for NewGUI
Closes #2