Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup pre-commit hooks #33

Merged
merged 10 commits into from
Apr 29, 2024
Merged

Setup pre-commit hooks #33

merged 10 commits into from
Apr 29, 2024

Conversation

samderanova
Copy link
Contributor

This PR uses pre-commit to set up pre-commit hooks for the following:

  • control-station/
    • Prettier
    • ESLint
    • tsc
  • pod-operation/
    • cargo fmt
    • cargo check
    • cargo clippy

@samderanova samderanova requested review from taesungh and a team April 9, 2024 21:21
@samderanova samderanova linked an issue Apr 9, 2024 that may be closed by this pull request
Set up pre-commit hooks #22
Closed
taesungh
taesungh requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, mainly one suggestion about structuring the npm scripts to use corresponding scripts for each app.

package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
taesungh
taesungh reviewed Apr 11, 2024
View reviewed changes
package.json Show resolved Hide resolved
taesungh
taesungh reviewed Apr 11, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
taesungh
taesungh approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting all of this up. Side note: pre-commit seems to not be maintained anymore, but we'll stick with this for now. We could maybe also look into using Turborepo in the future for simpler script delegation. Please squash during merge.

@samderanova samderanova merged commit accdc7a into main Apr 29, 2024
2 checks passed
SM-dot
SM-dot reviewed Apr 29, 2024
View reviewed changes
package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just for clarification "pod operation backend"- what exactly are we planning to have for this?

samderanova added a commit that referenced this pull request Apr 29, 2024
@samderanova
Setup pre-commit hooks (#33)
c18d628 
* Add pre-commit and a few basic hooks

* Add additional pre-commit hooks

* Add tsc pre-commit hook

* Miscellaneous fixes:

- Update .prettierrc
- Add pre-commit scripts to run
- Remove unused dependency husky

* Reorganize pre-commit hooks into subrepos

* Use tabs with width of 4 to format package.json

* Remove unecessary package.json elements, add author

* Update README.md with pre-commit hooks section

* Add test hook for control-station

* Add test hook for control-station
@taesungh taesungh deleted the setup/pre-commit-hooks branch June 2, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SM-dot SM-dot SM-dot approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up pre-commit hooks
3 participants
@samderanova @taesungh @SM-dot