Merged
Conversation
taesungh
requested changes
May 8, 2024
samderanova
requested changes
May 8, 2024
- changed to struct implementation - tracking A and B values - changed encoder names for simplicity
taesungh
reviewed
May 11, 2024
taesungh
reviewed
May 11, 2024
taesungh
reviewed
May 11, 2024
Member
taesungh
left a comment
taesungh
left a comment
There was a problem hiding this comment.
Could we also get the corresponding usage in a function in demo.rs?
V = Distance / Time Distance depends on the counter. If distance decreases, the velocity also decreases.
Only checking for a's last state match and not b in order to keep consistency and define a direction in order to decrease the counter accurately for each pulse.
…ystem into 11-pod-implement-wheel-encoder-measurements-in-rust
Contributor
|
velocity should work now (havent been able to test at high speeds, works at low), dist works fs |
samderanova
reviewed
May 18, 2024
taesungh
previously requested changes
May 18, 2024
Member
taesungh
left a comment
taesungh
left a comment
There was a problem hiding this comment.
Nice start, some questions about the implementation.
samderanova
approved these changes
May 18, 2024
taesungh
dismissed
their stale review
Will revisit improvements later. Squashing for now to unblock.
samderanova
approved these changes
May 18, 2024
This was referenced May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code has been modified to utilize the rppal library for GPIO communication, ensuring compatibility with Raspberry Pi devices and enhancing reliability and performance. Updates needed in the code after testing (making sure we are able to get an output from A and B both of the new wheel encoder and is measuring a pulse accurately):