Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LIM current readings from current sensor & ADC #62

Merged
merged 14 commits into from
May 25, 2024
Merged

Add LIM current readings from current sensor & ADC #62

merged 14 commits into from
May 25, 2024

Conversation

vrushang1234
Copy link
Contributor

Added and tested the code for hall effect sensor. Solves #34 .

taesungh
taesungh requested changes May 18, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, some things to clean up and some questions on usage.

@taesungh taesungh changed the title Hall effect Add LIM current readings from current sensor & ADC May 21, 2024
taesungh
taesungh requested changes May 21, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure what the constant values represent. Additionally, non-descriptive comments that provide minimal value only add clutter. Could you also rebase with the latest main branch as there are merge conflicts?

taesungh
taesungh reviewed May 22, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the formula, your changes still need to be rebased.

@taesungh taesungh mentioned this pull request May 24, 2024
Closed
taesungh
taesungh approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now, thanks for following the chores/suggestions. Please squash during merge.

SM-dot
SM-dot approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@SM-dot SM-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@vrushang1234 vrushang1234 requested a review from samderanova May 25, 2024 18:02
taesungh
taesungh approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be squashing.

@taesungh taesungh merged commit 36cf6a6 into main May 25, 2024
2 checks passed
This was referenced May 25, 2024
Closed
Closed
Open
@taesungh taesungh linked an issue May 27, 2024 that may be closed by this pull request
[Pod] Implement LIM current measurements from ADC via I2C #34
Closed
@taesungh taesungh deleted the hall-effect branch May 29, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh approved these changes

@SM-dot SM-dot SM-dot approved these changes

@samderanova samderanova Awaiting requested review from samderanova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pod] Implement LIM current measurements from ADC via I2C
4 participants
@vrushang1234 @samderanova @taesungh @SM-dot