-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Resolution Wheel Encoder #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having a separate copy, we'll want to modify the existing implementation in wheel_encoder.rs
Full resolution wheel encoder
- clean
get_velocity and read added to match previous code.
removed log import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes about implementation, I've already looked into addressing most of them. Noticed in testing we'll also need to update the version of RPPAL.
- `Pin::into_input` did not work properly with Raspberry Pi 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in lab -- works! tysm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since wheel encoder works as stated above and to unblock integration testing with other peripherals. We'll want to use meters instead of feet but we can do this in another issue.
A discussed in #58, this utilizes a more accurate approach to calculate distance and velocity. In case of under sampling, indicates an error to transition in the Faulted State for the FSM.
Changes
InputPin
with Raspberry Pi 5EncoderState
andEncoderDiff
with numeric traits derived fromnum_enum
Err