Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display sensor values in control station GUI #81

Merged
merged 24 commits into from
Jun 1, 2024
Merged

Display sensor values in control station GUI #81

merged 24 commits into from
Jun 1, 2024

Conversation

ryescholin
Copy link
Member

@ryescholin ryescholin commented May 27, 2024 •
edited by taesungh
Loading

Emit sensor values in pod_periodic (might move some to running_periodic) and display values in sensor boxes in GUI.
Resolves #44.

@taesungh taesungh marked this pull request as draft May 29, 2024 21:49
@vrushang1234 vrushang1234 marked this pull request as ready for review May 31, 2024 22:46
taesungh
taesungh requested changes Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. To keep the PR focused on a specific issue, please refrain from mixing changes that are out of scope. Some small issues and some minor suggestions.

control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/Sensors/SensorsContainer.tsx Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/Sensors/SensorsContainer.tsx Outdated Show resolved Hide resolved
control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/views/Dashboard/Dashboard.tsx Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
taesungh
taesungh approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock additional work on GUI, please make sure to squash during merge.

@vrushang1234 vrushang1234 merged commit dd20036 into main Jun 1, 2024
2 checks passed
@taesungh taesungh deleted the sensors_to_gui branch June 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrushang1234 vrushang1234 vrushang1234 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@taesungh taesungh taesungh approved these changes

@samderanova samderanova samderanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display sensor values in control station GUI
4 participants
@ryescholin @samderanova @taesungh @vrushang1234