Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement depth measurements from lidar camera #92

Merged
merged 16 commits into from
May 30, 2024
Merged

Implement depth measurements from lidar camera #92

merged 16 commits into from
May 30, 2024

Conversation

ryescholin
Copy link
Member

@ryescholin ryescholin commented May 29, 2024 •
edited by taesungh
Loading

not using rppal bc of lack of support -- tested w sam
Create Lidar abstraction to measure distance of object in line of sight.
Resolves #42.

@ryescholin ryescholin linked an issue May 29, 2024 that may be closed by this pull request
[Pod] Implement depth measurements from lidar camera #42
Closed
taesungh
taesungh reviewed May 29, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate there's no generic embedded-hal support. Perhaps we could eventually look into reworking the library implementation, but shouldn't be a huge concern now. Some minor notes about numeric conversions and improving clarity.

pod-operation/src/components/lidar.rs Outdated Show resolved Hide resolved
pod-operation/src/components/lidar.rs Outdated Show resolved Hide resolved
pod-operation/src/components/lidar.rs Outdated Show resolved Hide resolved
@ryescholin ryescholin requested review from taesungh and removed request for vrushang1234 May 29, 2024 22:55
taesungh
taesungh approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, trusting the device was tested and works.

@ryescholin ryescholin merged commit 797dd93 into main May 30, 2024
2 checks passed
@taesungh taesungh deleted the garminlidar branch May 31, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh approved these changes

@SM-dot SM-dot SM-dot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pod] Implement depth measurements from lidar camera
3 participants
@ryescholin @taesungh @SM-dot