Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Adding changes that print out the requested values #61

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adding changes that print out the requested values #61

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3edd2ea
first commit
enkaoua Oct 22, 2020
10d9d1b
Added connection function. Still to add: 2-way relationship
enkaoua Oct 22, 2020
fdf5ff6
Commenting out changes
i-gayo Oct 27, 2020
5dcb5b8
Attempt 2 just using dictionary of dictionaries
i-gayo Oct 27, 2020
fa1cc07
Printing out values from group
i-gayo Oct 27, 2020
c74ca15
Printed additional info
i-gayo Oct 27, 2020
be6eb94
Adding json files
i-gayo Oct 27, 2020
db9e8c9
Correcting comprehensions
i-gayo Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,25 +71,26 @@ def add_connection(self, friend, relationship):
[print(member['age']) for member_name, member in group.items()]

# 1. Max age of people in the group
ages = []
[ages.append(member['age']) for member_name, member in group.items()]
print("Maximum age of group: ", max(ages))
#Not proper comprehensions --> Comprehensions make a list already
#ages = []
#[ages.append(member['age']) for member_name, member in group.items()]

#Making use of proper comprehensions
ages = [person["age"] for person in group.values()]
print("Maximum age of group: ", max(ages))

# 2. Average (mean) number of relations among members of the group
no_relations = []
[no_relations.append(len(member['relations'])) for member_name, member in group.items()]
no_relations = [len(member['relations']) for member_name, member in group.items()]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, you could also make a function that calculates the mean from a list and use that on the output of the list

def mean(data):
    """Compute the average of a non-empty list of numbers."""
    return sum(data) / len(data)

mean([len(person["relations"]) for person in group.values()])  # 1.5

avg_relations = sum(no_relations) / len(no_relations)
print("Average number of relations: " , avg_relations)

# 3. The maximum age of people in the group that have at least one relation
ages_1relation = []
[ages_1relation.append(member['age']) for member_name, member in group.items() if len(member['relations']) > 0 ]
ages_1relation = [member['age'] for member_name, member in group.items() if len(member['relations']) > 0 ]
print("Max age of people in the group that have at least one relation: ", max(ages_1relation))

#4. Maximum age of people in the group that have at least one friend
print('friend' in group['Jill']['relations'].values()) #Test if friend is in relations.values
ages_wfriends = []
[ages_wfriends.append(member['age']) for member_name, member in group.items() if ('friend' in member['relations'].values())]
ages_wfriends = [member['age'] for member_name, member in group.items() if ('friend' in member['relations'].values())]
print('Maximum age of people w/at least one friend: ', max(ages_wfriends))

""" Working with JSON files """
Expand All @@ -102,15 +103,14 @@ def add_connection(self, friend, relationship):
json_format = json.dumps(group, indent = 3)

#Writes json formatted text to the json file
json_file.write(json_format)

json_file.write(json_format) #or could've done: json_file.write(json.dumps(group, indent =3 )
#Reading json file
with open('group.json', 'r') as json_file_read:
string_data = json_file_read.read()
print(string_data)
#print(string_data)

# Turning the read data into json format
group_read = json.loads(string_data)

#Access jill contents
print(group_read['Jill'])
#print(group_read['Jill'])