Skip to content

editorconfig update and cleanup for cf pages build - #119

Merged
a-thieme merged 2 commits into
UCLA-IRL:mainfrom
a-thieme:chore/pages-cleanup
Jul 21, 2026
Merged

editorconfig update and cleanup for cf pages build#119
a-thieme merged 2 commits into
UCLA-IRL:mainfrom
a-thieme:chore/pages-cleanup

Conversation

@a-thieme

Copy link
Copy Markdown
Member

editor didn't pick up json files, and package lock prevented cf builds, and the extra vuew-security package broke builds

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts repository tooling/config to improve Cloudflare Pages build reliability by removing a problematic dependency and ensuring EditorConfig formatting applies to JSON files as well.

Changes:

  • Removed the vuew dependency from package.json to avoid build issues caused by the *-security package.
  • Updated .editorconfig to include json so editors apply consistent formatting rules to JSON files.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Removes vuew from dependencies to prevent build breakage.
.editorconfig Adds json to the main glob so EditorConfig rules apply to JSON files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 47 to 52
"vue": "^3.5.18",
"vue-pdf-embed": "^2.1.2",
"vue-router": "^4.5.0",
"vue-virtual-scroller": "^2.0.0-beta.8",
"vue3-toastify": "^0.2.8",
"vuew": "^1.0.0-security",
"webworker-typed": "^1.0.5",

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

@a-thieme
a-thieme merged commit 38427a4 into UCLA-IRL:main Jul 21, 2026
2 checks passed
@a-thieme
a-thieme deleted the chore/pages-cleanup branch July 21, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants