Conversation Export Bug Fix #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You need to setup a payment method to use LintruleYou can fix that by putting in a card here. |
Base automatically changed from
dependency_injection
to
add_beam_serverless_ingest
March 12, 2024 22:20
rohan-uiuc
reviewed
Mar 13, 2024
| # call background task to upload to s3 | ||
|
|
||
| filename = course_name + '_' + str(uuid.uuid4()) + '_documents.zip' | ||
| s3_filepath = f"courses/{course_name}/{filename}" | ||
| # background task of downloading data - map it with above ID | ||
| executor = ProcessPoolExecutor() | ||
| executor.submit(self.export_data_in_bg, response, "documents", course_name, s3_filepath) | ||
| return {"response": 'Download from S3', "s3_path": s3_filepath} |
There was a problem hiding this comment.
Let's keep the response as Download from S3. The user message will be created on frontend on the basis of this response.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.