Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomic Code Clean-up #238

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Nomic Code Clean-up #238

merged 11 commits into from
Mar 29, 2024

Conversation

star-nox
Copy link
Member

@star-nox star-nox commented Mar 21, 2024

Ingest faces issue because of failing nomic log attempts.

Reasons for failed logs - map is rebuilding and gets locked for access. All subsequent calls to nomic_log after the 1st attempt fail.

Solution -

  1. skip nomic log altogether if map is locked
  2. keep track of last uploaded id in both maps
  3. modify the log function to retrieve this last uploaded id and log all records since
  4. what if there are a large number of unlogged records? it will increase overall ingestion time. can we move ingest to background? or is it okay as it is in beam?

Copy link

You need to setup a payment method to use Lintrule

You can fix that by putting in a card here.

@star-nox star-nox marked this pull request as draft March 21, 2024 23:16
@star-nox star-nox self-assigned this Mar 21, 2024
@star-nox star-nox marked this pull request as ready for review March 28, 2024 22:03
@star-nox star-nox requested a review from KastanDay March 28, 2024 22:04
Copy link
Member

@KastanDay KastanDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A complicated refactor to store all the documents that have yet to be added into nomic, but a necessary approach since we're using their service in a weird (cool) way. Thanks!

@KastanDay KastanDay merged commit d6b5fb8 into main Mar 29, 2024
1 check passed
@KastanDay KastanDay deleted the nomic-refactor branch March 29, 2024 01:16
Copy link

sentry-io bot commented Mar 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ InvalidRequestError: Unsupported OpenAI-Version header provided: 2023-05-15. (HINT: you can provide any of the followi... logToNomic View Issue
  • ‼️ IndexError: list index out of range logToNomic View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants